changeset 947:c7fea2f68d09 default tip

Documented the workaround for the parent bug.
author John Schneiderman <JohnMS@member.fsf.org>
date Wed, 22 Nov 2023 18:50:28 +0100
parents a5c5296ca17f
children
files ChangeLog src/foundation/external/foundation/QtMemory.hpp
diffstat 2 files changed, 2 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/ChangeLog	Wed Nov 22 17:01:37 2023 +0100
+++ b/ChangeLog	Wed Nov 22 18:50:28 2023 +0100
@@ -20,7 +20,7 @@
 XXXX-XX-XX John Schneiderman <JohnMS_AT_member_DOT_fsf_DOT_org> 0.6.0
 	* Development #1: Expanded the Qt memory validation to validate the parent hierarchy.
 	* Development #1: Expanded the Qt memory validation to validate the parent hierarchy.
-	* Development #1: Updated to Pecunia 0.6.
+	* Development #9: Updated to Pecunia 0.6.
 	* Development #1: Updated CMake to check the compiler for what additional compiler checks to
 			add.
 	* Development #1: Adjusted the ObserverPtr to be more aligned with C++ STD smart pointers.
--- a/src/foundation/external/foundation/QtMemory.hpp	Wed Nov 22 17:01:37 2023 +0100
+++ b/src/foundation/external/foundation/QtMemory.hpp	Wed Nov 22 18:50:28 2023 +0100
@@ -293,7 +293,7 @@
 {
 	QtPtr<BaseType> obj{new ObjectType{std::forward<ObjectArgTypes>(objectArgs)...}};
 
-	// TODO: Why does the QTreeWidgetItem parent call returns null when it is not null?
+	// BUG: Workaround for the QTreeWidgetItem parent call returning null even though the supplied parent is not null with Qt 5.15.
 	if constexpr (std::is_same_v<::QObject, BaseType>)
 		assert(obj->parent() != nullptr && "All Qt objects must have a parent.");
 	return obj;